Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Inline AbstractServerImplBuilder #7432

Merged
merged 3 commits into from Sep 18, 2020
Merged

core: Inline AbstractServerImplBuilder #7432

merged 3 commits into from Sep 18, 2020

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Sep 16, 2020 •
edited

A part of #7211.

Note to reviewers

Compare AbstractServerImplBuilder in ServerImplBuilder:

git diff f04f33efe:core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java 98a944d:core/src/main/java/io/grpc/internal/ServerImplBuilder.java

Compare AbstractServerImplBuilderTest in ServerImplBuilderTest:

git diff f04f33efe:core/src/test/java/io/grpc/internal/AbstractServerImplBuilderTest.java 98a944d:core/src/test/java/io/grpc/internal/ServerImplBuilderTest.java

@sergiitk sergiitk marked this pull request as ready for review September 16, 2020 20:56
@sergiitk sergiitk merged commit b571f23 into grpc:master Sep 18, 2020
@sergiitk sergiitk deleted the remove-abstract-server-builder branch September 18, 2020 20:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergiitk @ejona86