Upgrading Conscrypt to 2.5.1 (backport of #7342 to 1.32.x) #7411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es in the ALTS code. (cl/308901367)" This reverts commit a7bca23.
voidzcy
approved these changes
Sep 18, 2020
ejona86
requested changes
Sep 23, 2020
There was a problem hiding this comment.
We typically don't upgrade to new minor versions of dependencies in a patch release, unless there were serious bugs. This provides a performance improvement, which isn't normally acceptable for a patch release/backport. And upgrading to Conscrypt 2.5.1 required working through a lot of problems, such that it seems this upgrade is more risky than most.
|
Thank you for the comment! Closing this PR. |
|
In talking "offline," we realized that we don't probably need the Conscrypt upgrade; we just need the revert and users are free to upgrade Conscrypt themselves. That would be a fine approach. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7342 to 1.32.x