Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel builders extend public API #7359

Merged
merged 6 commits into from Sep 2, 2020
Merged

Channel builders extend public API #7359

merged 6 commits into from Sep 2, 2020

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Aug 25, 2020 •
edited

The first part of #7211: Hide AbstractManagedChannelImplBuilder from public API.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 25, 2020 •
edited

CLA Check
The committers are authorized under a signed CLA.

@sergiitk sergiitk requested a review from ejona86 August 25, 2020 22:27
@sergiitk sergiitk mentioned this pull request Aug 31, 2020
Merged
ejona86
ejona86 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor stuff except for the TestServiceClient comment, but that one is easy.

core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java Outdated Show resolved Hide resolved
core/src/test/java/io/grpc/internal/ManagedChannelImplTest.java Outdated Show resolved Hide resolved
core/src/main/java/io/grpc/internal/ManagedChannelImplBuilder.java Outdated Show resolved Hide resolved
core/src/test/java/io/grpc/internal/ServiceConfigErrorHandlingTest.java Outdated Show resolved Hide resolved
cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java Outdated Show resolved Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/TestServiceClient.java Outdated Show resolved Hide resolved
netty/src/test/java/io/grpc/netty/NettyChannelBuilderTest.java Outdated Show resolved Hide resolved
@sergiitk sergiitk changed the title various: Hide AbstractManagedChannelImplBuilder from public API various: Channel builders extend public API Sep 1, 2020
@sergiitk sergiitk changed the title various: Channel builders extend public API Channel builders extend public API Sep 1, 2020
@sergiitk sergiitk force-pushed the channel-builders-extend-forwarding branch 2 times, most recently from c50d3e6 to 9cd0e1a Compare September 2, 2020 02:04
@sergiitk sergiitk force-pushed the channel-builders-extend-forwarding branch from 8f68dba to b2365a1 Compare September 2, 2020 16:41
@sergiitk sergiitk merged commit e335cb3 into grpc:master Sep 2, 2020
@sergiitk sergiitk deleted the channel-builders-extend-forwarding branch September 2, 2020 17:29
@sergiitk sergiitk mentioned this pull request Sep 11, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergiitk @ejona86