Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-auth-library-java to 0.13.0 #5365

Merged
merged 2 commits into from Feb 15, 2019
Merged

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Feb 14, 2019

0.13.0 is the latest version.

This honestly doesn't do much since any user of our auth API will be
depending on the library themselves (we only depend on the interface; no
implementation). But getting past 0.9.1 may encourage our users to use a
newer version with better JWT handling and 0.9.1 was released 10 months
ago, so we're overdue for an update.

Fixes #4700


CC @elharo

Note that this did not make the cut for the 1.19 release. It could easily be backported, but I'm not sure there's much point.

@ejona86 ejona86 changed the title Update to google-auth-library-java 0.13.0 Update google-auth-library-java to 0.13.0 Feb 14, 2019
0.13.0 is the latest version.

This honestly doesn't do much since any user of our auth API will be
depending on the library themselves (we only depend on the interface; no
implementation). But getting past 0.9.1 may encourage our users to use a
newer version with better JWT handling and 0.9.1 was released 10 months
ago, so we're overdue for an update.

Fixes grpc#4700
This didn't trigger when -PskipCodegen=false, and it's unclear why.
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit b7b7322 into grpc:master Feb 15, 2019
@ejona86 ejona86 deleted the update-auth-lib branch February 15, 2019 17:38
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency upgrades
2 participants