servlet: Update Servlet container test versions #11212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
reviewed
May 16, 2024
servlet/src/jettyTest/java/io/grpc/servlet/JettyTransportTest.java
Outdated
Show resolved
Hide resolved
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
May 20, 2024
|
@niloc132, thank you! Thanks for handling the Jetty bug and all. |
sergiitk
approved these changes
May 23, 2024
sergiitk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies that latest versions of Tomcat/Undertow/Jetty pass integration tests - I manually verified that all ignored tests still fail.
Two tests failed in Jetty, it appears that the integration test anticipates that the server implementation is willing to send larger trailers than the client SETTINGS frame allows for. Since the server refuses to send too large of headers/trailers, the client does not receive the too-large payloads, and doesn't fail with the expected message. This change was introduced in Jetty 10.0.15/11.0.11. Those tests are ignored.