rls: Make LinkedHashLruCache non-threadsafe #11203
Merged
+88
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachingRlsLbClient already calls it with a lock held. The only reason the cache needs to manage the lock itself is for the periodic cleanup. Let the consumer of the cache handle the timer.
larry-safran
approved these changes
May 28, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachingRlsLbClient already calls it with a lock held. The only reason the cache needs to manage the lock itself is for the periodic cleanup. Let the consumer of the cache handle the timer.
Just noticed I hadn't sent this out. This was done around the same time as #11124 (unrelated to the fallback RLS PR I just sent out).