Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls: Add gauge metric recording #11175

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

temawi
Copy link
Contributor

@temawi temawi commented May 8, 2024

Adds these gauges:

  • grpc.lb.rls.cache_entries
  • grpc.lb.rls.cache_size

Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
@temawi temawi requested a review from ejona86 May 8, 2024 18:48
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing cache_size part of the test is the main thing to fix.

rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java Outdated Show resolved Hide resolved
rls/src/test/java/io/grpc/rls/CachingRlsLbClientTest.java Outdated Show resolved Hide resolved
rls/src/test/java/io/grpc/rls/RlsLoadBalancerTest.java Outdated Show resolved Hide resolved
@temawi temawi merged commit 511b9c3 into grpc:master May 8, 2024
13 checks passed
@temawi temawi deleted the rls-metrics-gauges branch May 8, 2024 22:15
@DNVindhya DNVindhya added the TODO:backport PR needs to be backported. Removed after backport complete label May 8, 2024
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request May 9, 2024
Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
ejona86 pushed a commit that referenced this pull request May 9, 2024
Adds these gauges:
- grpc.lb.rls.cache_entries
- grpc.lb.rls.cache_size
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants