Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: Downgrade mockito to 4.4.0 #10602

Merged
merged 1 commit into from Oct 9, 2023
Merged

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Oct 9, 2023

Starting from version 4.5.0 Mockito uses the Java stream APIs, which are not available on Android API levels < 24. This has been causing the Android integration tests for API levels 21, 22 and 23 to fail.

This is to address #10457.

Starting from version 4.5.0 Mockito uses the Java stream APIs, which are
not available on Android API levels < 24. This has been causing the
Android integration tests for API levels 21, 22 and 23 to fail.
@ejona86
Copy link
Member

ejona86 commented Oct 9, 2023

FWIW, I wouldn't be against getting rid of mockito in AbstractInteropTest. But that's a larger effort.

@temawi temawi merged commit e488b67 into grpc:master Oct 9, 2023
14 checks passed
@temawi temawi deleted the mockito-4.4.0 branch October 9, 2023 20:29
@ejona86
Copy link
Member

ejona86 commented Oct 9, 2023

@temawi, we should probably backport this for the release, so the CI is healthy on that branch.

@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Oct 9, 2023
@temawi temawi removed the TODO:backport PR needs to be backported. Removed after backport complete label Oct 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants