Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side timeout mechanism #10360

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 18 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
183 changes: 183 additions & 0 deletions util/src/main/java/io/grpc/util/SerializingServerCall.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,183 @@
/*
* Copyright 2017 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc.util;

import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.SettableFuture;
import io.grpc.Attributes;
import io.grpc.ExperimentalApi;
import io.grpc.ForwardingServerCall;
import io.grpc.Metadata;
import io.grpc.ServerCall;
import io.grpc.Status;
import io.grpc.internal.SerializingExecutor;
import java.util.concurrent.ExecutionException;
import javax.annotation.Nullable;

/**
* A {@link ServerCall} that wraps around a non thread safe delegate and provides thread safe
* access by serializing everything on an executor.
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/2189")
class SerializingServerCall<ReqT, RespT> extends
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is extracted from TransmitStatusRuntimeExceptionInterceptor.

ForwardingServerCall.SimpleForwardingServerCall<ReqT, RespT> {
private static final String ERROR_MSG = "Encountered error during serialized access";
private final SerializingExecutor serializingExecutor =
new SerializingExecutor(MoreExecutors.directExecutor());
private boolean closeCalled = false;

SerializingServerCall(ServerCall<ReqT, RespT> delegate) {
super(delegate);
}

@Override
public void sendMessage(final RespT message) {
serializingExecutor.execute(new Runnable() {
@Override
public void run() {
SerializingServerCall.super.sendMessage(message);
}
});
}

@Override
public void request(final int numMessages) {
serializingExecutor.execute(new Runnable() {
@Override
public void run() {
SerializingServerCall.super.request(numMessages);
}
});
}

@Override
public void sendHeaders(final Metadata headers) {
serializingExecutor.execute(new Runnable() {
@Override
public void run() {
SerializingServerCall.super.sendHeaders(headers);
}
});
}

@Override
public void close(final Status status, final Metadata trailers) {
serializingExecutor.execute(new Runnable() {
@Override
public void run() {
if (!closeCalled) {
closeCalled = true;

SerializingServerCall.super.close(status, trailers);
}
}
});
}

@Override
public boolean isReady() {
final SettableFuture<Boolean> retVal = SettableFuture.create();
serializingExecutor.execute(new Runnable() {

Check warning on line 94 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L93-L94

Added lines #L93 - L94 were not covered by tests
@Override
public void run() {
retVal.set(SerializingServerCall.super.isReady());
}

Check warning on line 98 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L97-L98

Added lines #L97 - L98 were not covered by tests
});
try {
return retVal.get();
} catch (InterruptedException e) {
throw new RuntimeException(ERROR_MSG, e);
} catch (ExecutionException e) {
throw new RuntimeException(ERROR_MSG, e);

Check warning on line 105 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L101-L105

Added lines #L101 - L105 were not covered by tests
}
}

@Override
public boolean isCancelled() {
final SettableFuture<Boolean> retVal = SettableFuture.create();
serializingExecutor.execute(new Runnable() {

Check warning on line 112 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L111-L112

Added lines #L111 - L112 were not covered by tests
@Override
public void run() {
retVal.set(SerializingServerCall.super.isCancelled());
}

Check warning on line 116 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L115-L116

Added lines #L115 - L116 were not covered by tests
});
try {
return retVal.get();
} catch (InterruptedException e) {
throw new RuntimeException(ERROR_MSG, e);
} catch (ExecutionException e) {
throw new RuntimeException(ERROR_MSG, e);

Check warning on line 123 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L119-L123

Added lines #L119 - L123 were not covered by tests
}
}

@Override
public void setMessageCompression(final boolean enabled) {
serializingExecutor.execute(new Runnable() {

Check warning on line 129 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L129

Added line #L129 was not covered by tests
@Override
public void run() {
SerializingServerCall.super.setMessageCompression(enabled);
}

Check warning on line 133 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L132-L133

Added lines #L132 - L133 were not covered by tests
});
}

Check warning on line 135 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L135

Added line #L135 was not covered by tests

@Override
public void setCompression(final String compressor) {
serializingExecutor.execute(new Runnable() {

Check warning on line 139 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L139

Added line #L139 was not covered by tests
@Override
public void run() {
SerializingServerCall.super.setCompression(compressor);
}

Check warning on line 143 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L142-L143

Added lines #L142 - L143 were not covered by tests
});
}

Check warning on line 145 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L145

Added line #L145 was not covered by tests

@Override
public Attributes getAttributes() {
final SettableFuture<Attributes> retVal = SettableFuture.create();
serializingExecutor.execute(new Runnable() {

Check warning on line 150 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L149-L150

Added lines #L149 - L150 were not covered by tests
@Override
public void run() {
retVal.set(SerializingServerCall.super.getAttributes());
}

Check warning on line 154 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L153-L154

Added lines #L153 - L154 were not covered by tests
});
try {
return retVal.get();
} catch (InterruptedException e) {
throw new RuntimeException(ERROR_MSG, e);
} catch (ExecutionException e) {
throw new RuntimeException(ERROR_MSG, e);

Check warning on line 161 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L157-L161

Added lines #L157 - L161 were not covered by tests
}
}

@Nullable
@Override
public String getAuthority() {
final SettableFuture<String> retVal = SettableFuture.create();
serializingExecutor.execute(new Runnable() {

Check warning on line 169 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L168-L169

Added lines #L168 - L169 were not covered by tests
@Override
public void run() {
retVal.set(SerializingServerCall.super.getAuthority());
}

Check warning on line 173 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L172-L173

Added lines #L172 - L173 were not covered by tests
});
try {
return retVal.get();
} catch (InterruptedException e) {
throw new RuntimeException(ERROR_MSG, e);
} catch (ExecutionException e) {
throw new RuntimeException(ERROR_MSG, e);

Check warning on line 180 in util/src/main/java/io/grpc/util/SerializingServerCall.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/SerializingServerCall.java#L176-L180

Added lines #L176 - L180 were not covered by tests
}
}
}
130 changes: 130 additions & 0 deletions util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
/*
* Copyright 2023 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc.util;

import io.grpc.Context;
import io.grpc.ExperimentalApi;
import io.grpc.ForwardingServerCallListener;
import io.grpc.Metadata;
import io.grpc.ServerCall;
import io.grpc.ServerCallHandler;
import io.grpc.ServerInterceptor;

/**
* An optional ServerInterceptor that can interrupt server calls that are running for too long time.
* In this way, it prevents problematic code from using up all threads.
*
* <p>How to use: you can add it to your server using ServerBuilder#intercept(ServerInterceptor).
*
* <p>Limitation: it only applies the timeout to unary calls
* (streaming calls will still run without timeout).
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/10361")
public class ServerCallTimeoutInterceptor implements ServerInterceptor {

private final ServerTimeoutManager serverTimeoutManager;

public ServerCallTimeoutInterceptor(ServerTimeoutManager serverTimeoutManager) {
this.serverTimeoutManager = serverTimeoutManager;
}

@Override
public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(
ServerCall<ReqT, RespT> serverCall,
Metadata metadata,
ServerCallHandler<ReqT, RespT> serverCallHandler) {
// Only intercepts unary calls because the timeout is inapplicable to streaming calls.
if (serverCall.getMethodDescriptor().getType().clientSendsOneMessage()) {
ServerCall<ReqT, RespT> serializingServerCall = new SerializingServerCall<>(serverCall);
Context.CancellableContext timeoutContext =
serverTimeoutManager.startTimeoutContext(serializingServerCall);
if (timeoutContext != null) {
return new TimeoutServerCallListener<>(
serverCallHandler.startCall(serializingServerCall, metadata),
timeoutContext,
serverTimeoutManager);
}
}
return serverCallHandler.startCall(serverCall, metadata);
}

/** A listener that intercepts RPC callbacks for timeout control. */
static class TimeoutServerCallListener<ReqT>
extends ForwardingServerCallListener.SimpleForwardingServerCallListener<ReqT> {

private final Context.CancellableContext context;
private final ServerTimeoutManager serverTimeoutManager;

private TimeoutServerCallListener(
ServerCall.Listener<ReqT> delegate,
Context.CancellableContext context,
ServerTimeoutManager serverTimeoutManager) {
super(delegate);
this.context = context;
this.serverTimeoutManager = serverTimeoutManager;
}

@Override
public void onMessage(ReqT message) {
Context previous = context.attach();
try {
super.onMessage(message);
} finally {
context.detach(previous);
}
}

/**
* Intercepts onHalfClose() because the application RPC method is called in it. See
* io.grpc.stub.ServerCalls.UnaryServerCallHandler.UnaryServerCallListener
*/
@Override
public void onHalfClose() {
serverTimeoutManager.withInterruption(context, super::onHalfClose);
}

@Override
public void onCancel() {
Context previous = context.attach();

Check warning on line 102 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L102

Added line #L102 was not covered by tests
try {
super.onCancel();

Check warning on line 104 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L104

Added line #L104 was not covered by tests
} finally {
context.detach(previous);

Check warning on line 106 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L106

Added line #L106 was not covered by tests
}
}

Check warning on line 108 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L108

Added line #L108 was not covered by tests

@Override
public void onComplete() {
Context previous = context.attach();
try {
super.onComplete();
} finally {
context.detach(previous);
}
}

@Override
public void onReady() {
Context previous = context.attach();

Check warning on line 122 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L122

Added line #L122 was not covered by tests
try {
super.onReady();

Check warning on line 124 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L124

Added line #L124 was not covered by tests
} finally {
context.detach(previous);

Check warning on line 126 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L126

Added line #L126 was not covered by tests
}
}

Check warning on line 128 in util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java

View check run for this annotation

Codecov / codecov/patch

util/src/main/java/io/grpc/util/ServerCallTimeoutInterceptor.java#L128

Added line #L128 was not covered by tests
}
}