Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bidi Blocking Stub #10318

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Bidi Blocking Stub #10318

wants to merge 50 commits into from

Commits on Apr 14, 2023

  1. checkpoint

    @larry-safran
    larry-safran committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    138c1ad View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Checkpoint

    @larry-safran
    larry-safran committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9b2ab2a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Initial pass complete

    @larry-safran
    larry-safran committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    fd26f23 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Change blockingWriteOrRead to be either/or rather than and/or.

    @larry-safran
    larry-safran committed May 2, 2023
    Configuration menu
    Copy the full SHA
    515c7c4 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Update javadoc and checking for write legality

    @larry-safran
    larry-safran committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4e63935 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Feedback from API review

    @larry-safran
    larry-safran committed May 4, 2023
    Configuration menu
    Copy the full SHA
    09095ae View commit details
    Browse the repository at this point in the history

  2. Generate blocking bidi stream method

    @larry-safran
    larry-safran committed May 4, 2023
    Configuration menu
    Copy the full SHA
    7d87f74 View commit details
    Browse the repository at this point in the history

  3. Add generated method for bidi streaming

    @larry-safran
    larry-safran committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2fe79a9 View commit details
    Browse the repository at this point in the history

  4. Restore BlockingServerStream's QueueingListener to the original.

    @larry-safran
    larry-safran committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b2de4c7 View commit details
    Browse the repository at this point in the history

  5. Fix tests and formatting

    @larry-safran
    larry-safran committed May 4, 2023
    Configuration menu
    Copy the full SHA
    4f9ca2d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Implement example

    @larry-safran
    larry-safran committed May 5, 2023
    Configuration menu
    Copy the full SHA
    70a1b1b View commit details
    Browse the repository at this point in the history

  2. example fixes

    @larry-safran
    larry-safran committed May 5, 2023
    Configuration menu
    Copy the full SHA
    7fdb53a View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Fixed while condition

    @larry-safran
    larry-safran committed May 6, 2023
    Configuration menu
    Copy the full SHA
    d380b7d View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Checkpoint

    @larry-safran
    larry-safran committed May 25, 2023
    Configuration menu
    Copy the full SHA
    4dedccd View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Updated examples and removed the writeOrRead that was confusing.

    @larry-safran
    larry-safran committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    95b6b2f View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Update interface to reflect latest conversations and make all tests w… 

    …ork. Multiple threads blocking on a single ClientCall was hanging.
    @larry-safran
    larry-safran committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    713d74a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Updates based upon design review.

    @larry-safran
    larry-safran committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    60af084 View commit details
    Browse the repository at this point in the history

  2. Fix test case.

    @larry-safran
    larry-safran committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    3bd8b8c View commit details
    Browse the repository at this point in the history

  3. Remove waitForReady.

    @larry-safran
    larry-safran committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d747b82 View commit details
    Browse the repository at this point in the history

  4. fix halfClose.

    @larry-safran
    larry-safran committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    1b63ada View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. add padding to messages so that flow control actually happens on writ… 

    …es. Fix multithreading logic in ThreadExecutor.
    @larry-safran
    larry-safran committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    7beeaf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Fix style errors

    @larry-safran
    larry-safran committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d3a89d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Merge branch 'master' into blocking

    @larry-safran
    larry-safran committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    76f1892 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Add comment

    @larry-safran
    larry-safran committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    5593196 View commit details
    Browse the repository at this point in the history

  2. Fix cancel test

    @larry-safran
    larry-safran committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    09226c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Rename BlockingBiDiStream.java to BlockingClientCall

    @larry-safran
    larry-safran committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    ef8d28a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Improve test reporting and increase delay amount to reduce flakes.

    @larry-safran
    larry-safran committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5f9d701 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Make test times all relative to DELAY_MILLIS so that can be changed w… 

    …ithout affecting the asserts.
    @larry-safran
    larry-safran committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    fa3343d View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Add a second blocking stub with a V2 to differentiate it from the exi… 

    …sting one. Have the blockingV2 create entries for all 4 types of rpcs. Remove the bidi streaming from the old BlockingStub
    @larry-safran
    larry-safran committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    2ff162e View commit details
    Browse the repository at this point in the history

  2. Add android-interop generated Grpc files.

    @larry-safran
    larry-safran committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    235a49b View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Changed the generator to use '?' instead of request type for return v… 

    …alue of stub on blocking server streaming calls

Also in generator put a space between request and response types in the generic definition and use java.lang.String everywhere as has already been done in master
    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d2dec86 View commit details
    Browse the repository at this point in the history

  2. Add methods to ClientCalls for both blocking client and server stream… 

    … and move the logic out of the generated file into the server streaming method
    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2104a0f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into blocking

    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6c06c90 View commit details
    Browse the repository at this point in the history

  4. Fix the logic so that onReady is actually handled correctly

    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c08eb90 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'blocking' of https://github.com/larry-safran/grpc-java … 

    …into blocking
    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    75d894e View commit details
    Browse the repository at this point in the history

  6. Fix listener handling of onReady

    @larry-safran
    larry-safran committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    6921d6a View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Remove generics from the listener.

    @larry-safran
    larry-safran committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    7a62a5a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Respond to code review comments

    @larry-safran
    larry-safran committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0252972 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Rsstore ThreadlessExecutor to the way it was and use a new ThreadSafe… 

    …ThreadlessExecutor class for multithreading.
    @larry-safran
    larry-safran committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    ee8d7d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update stub/src/main/java/io/grpc/stub/ClientCalls.java 

    Co-authored-by: Eric Anderson <ejona@google.com>
    @larry-safran @ejona86
    larry-safran and ejona86 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c245f75 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Change locking logic in ThreadSafeThreadlessExecutor from using LockS… 

    …upport to Lock & Condition
    @larry-safran
    larry-safran committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5c70deb View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Update javadoc to make it clear that flow control is a network thing.

    @larry-safran
    larry-safran committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7cd0df6 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Eliminate synchronized from waitAndDrain, just using waiterLock.

    @larry-safran
    larry-safran committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    78d9ce0 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Cleanup with Eric

    @larry-safran
    larry-safran committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0ac6ad6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Respond to Review comments. Need to update generated code to throw St… 

    …atusException for server streaming and regenerate stubs.
    @larry-safran
    larry-safran committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    61ca3c8 View commit details
    Browse the repository at this point in the history

  2. Add StatusException to the throws list of blockingV2ServerStreamingCall

    @larry-safran
    larry-safran committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d379393 View commit details
    Browse the repository at this point in the history

  3. Updated generated code with StatusException for blockingV2ServerStrea… 

    …mingCall
    @larry-safran
    larry-safran committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ed3809f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Add missing generated classes

    @larry-safran
    larry-safran committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    53a0766 View commit details
    Browse the repository at this point in the history

  2. change StatusRuntimeException to StatusException in catch blocks

    @larry-safran
    larry-safran committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    05151ff View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Updated examples to handle blockingV2ServerStreamingCall throwing Sta… 

    …tusException
    @larry-safran
    larry-safran committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    244be52 View commit details
    Browse the repository at this point in the history