example-orca: fix lost streamTracerFactor #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
added
the
TODO:backport
ejona86
approved these changes
Jul 25, 2022
...ample-orca/src/main/java/io/grpc/examples/orca/CustomBackendMetricsLoadBalancerProvider.java
Outdated
Show resolved
Hide resolved
| + orcaLoadReport); | ||
| } | ||
| }; | ||
| if (result.getStreamTracerFactory() == null) { |
There was a problem hiding this comment.
Note that this code demonstrates that we should probably improve the helpers (either by allowing null or by a more convenient method). But we can fix that later.
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Jul 28, 2022
YifeiZhuang
added a commit
that referenced
this pull request
Jul 28, 2022
YifeiZhuang
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.