Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: fix orca example to use new ORCA API #9403

Merged
merged 3 commits into from Jul 22, 2022

Conversation

YifeiZhuang
Copy link
Contributor

No description provided.

@YifeiZhuang YifeiZhuang requested a review from ejona86 July 20, 2022 22:34
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be fair to implement toString in MetricReport if you want.

The fact this wasn't noticed earlier means we are failing to build this in our CI. It needs to be added

pushd examples
./gradlew build $GRADLE_FLAGS
# --batch-mode reduces log spam
mvn verify --batch-mode
popd
pushd examples/example-alts
../gradlew build $GRADLE_FLAGS
popd
pushd examples/example-hostname
../gradlew build $GRADLE_FLAGS
mvn verify --batch-mode
popd
pushd examples/example-tls
../gradlew build $GRADLE_FLAGS
mvn verify --batch-mode
popd
pushd examples/example-jwt-auth
../gradlew build $GRADLE_FLAGS
mvn verify --batch-mode
popd
pushd examples/example-xds
../gradlew build $GRADLE_FLAGS
popd

@YifeiZhuang YifeiZhuang merged commit 58cd6e1 into grpc:master Jul 22, 2022
@YifeiZhuang YifeiZhuang added the TODO:backport PR needs to be backported. Removed after backport complete label Jul 22, 2022
@YifeiZhuang YifeiZhuang deleted the fix-orca-example branch July 22, 2022 20:07
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Jul 28, 2022
@YifeiZhuang YifeiZhuang removed the TODO:backport PR needs to be backported. Removed after backport complete label Jul 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants