xds: do not expose orca proto in ORCA api #9366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Jul 14, 2022
services/src/main/java/io/grpc/services/CallMetricRecorder.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/services/CallMetricRecorder.java
Outdated
Show resolved
Hide resolved
| */ | ||
| void onLoadReport(OrcaLoadReport report); | ||
| void onLoadReport(CallMetricRecorder.CallMetricReport report); |
There was a problem hiding this comment.
We can do it as a follow-up, but it probably is appropriate to move CallMetricReport to a top-level class in services?
ejona86
approved these changes
Jul 15, 2022
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Jul 22, 2022
The fix avoids shaded dependency of orca protos
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Jul 26, 2022
The fix avoids shaded dependency of orca protos
YifeiZhuang
added a commit
that referenced
this pull request
Jul 28, 2022
The fix avoids shaded dependency of orca protos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO(@zivy): fix xds dependency and remove shadow plugin(?) in :grpc-interop-test