Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Workaround retry causing memory leak #9360

Merged
merged 2 commits into from Jul 15, 2022
Merged

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 11, 2022

Data is getting orphaned sitting in MessageFramer. This hack thus always
flushes data out of the framer so no data can remain sitting there.

See #9340

Data is getting orphaned sitting in MessageFramer. This hack thus always
flushes data out of the framer so no data can remain sitting there.

See grpc#9340
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Jul 11, 2022
@ejona86 ejona86 requested a review from YifeiZhuang July 11, 2022 20:43
@ejona86 ejona86 merged commit 4cb1fba into grpc:master Jul 15, 2022
@ejona86 ejona86 deleted the retry-flush branch July 15, 2022 22:25
@ejona86
Copy link
Member Author

ejona86 commented Jul 15, 2022

@YifeiZhuang, I will backport this after the 1.48.0 release for the 1.48.1 release. The 1.48.0 release has been delayed quite a bit and to have this be further tested would delay it further.

@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Jul 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants