xds: import envoy proto #8145
Merged
xds: import envoy proto #8145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
approved these changes
May 4, 2021
| @@ -18,7 +18,7 @@ | |||
| set -e | |||
| BRANCH=main | |||
| # import VERSION from one of the google internal CLs | |||
| VERSION=ac9a2637336decdcc52c24add5e8fc39edebb962 | |||
| VERSION=8b9b87702885beb324dadb349cbcb06d037c956e | |||
There was a problem hiding this comment.
Is bumping the version necessary for importing rbac protos?
There was a problem hiding this comment.
Good question. Looks like not necessary. The only difference i noticed in v3.rbac is just deprecation annotation changes. And then all the dependency chain. Shall we be careful about bumping up envoy version? Things added like quic_config.proto looks something that we never need.
There was a problem hiding this comment.
Shall we be careful about bumping up envoy version?
If we only add protos, without bumping the version, the PR will look much simple. If our version is too out of date from google3, then bumping the version is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in
v3.rbacprotos as dependency of RBAC engine implementation.