Skip to content

Commit

Permalink
Do not extend public interface that is already accessible.
Browse files Browse the repository at this point in the history
  • Loading branch information
voidzcy committed Apr 16, 2021
1 parent 1951bc2 commit ba9fb8d
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import io.grpc.CallOptions;
import io.grpc.ClientInterceptor;
import io.grpc.ServerInterceptor;
import io.grpc.protobuf.services.BinaryLogSink;
import java.io.IOException;
import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable;
Expand Down
29 changes: 0 additions & 29 deletions services/src/main/java/io/grpc/services/BinaryLogSink.java

This file was deleted.

1 change: 1 addition & 0 deletions services/src/main/java/io/grpc/services/BinlogHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
import io.grpc.binarylog.v1.GrpcLogEntry;
import io.grpc.binarylog.v1.GrpcLogEntry.EventType;
import io.grpc.binarylog.v1.Message;
import io.grpc.protobuf.services.BinaryLogSink;
import java.net.Inet4Address;
import java.net.Inet6Address;
import java.net.InetAddress;
Expand Down
2 changes: 1 addition & 1 deletion services/src/main/java/io/grpc/services/TempFileSink.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* The output file goes to the JVM's temp dir with a prefix of BINARY_INFO. The proto messages
* are written serially using {@link MessageLite#writeDelimitedTo(OutputStream)}.
*/
class TempFileSink implements BinaryLogSink {
class TempFileSink implements io.grpc.protobuf.services.BinaryLogSink {
private static final Logger logger = Logger.getLogger(TempFileSink.class.getName());

private final String outPath;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import io.grpc.internal.NoopClientCall;
import io.grpc.internal.NoopServerCall;
import io.grpc.protobuf.StatusProto;
import io.grpc.protobuf.services.BinaryLogSink;
import io.grpc.services.BinlogHelper.FactoryImpl;
import io.grpc.services.BinlogHelper.MaybeTruncated;
import io.grpc.services.BinlogHelper.SinkWriter;
Expand Down

0 comments on commit ba9fb8d

Please sign in to comment.