Skip to content

Commit

Permalink
Downgrade Netty to 4.1.93-Final
Browse files Browse the repository at this point in the history
Our benchmarks saw a serious performance decrease with the upgrade from
Netty 4.1.88 to 4.1.94. The problem was tracked down to a single PR in
4.1.94, so we avoid 4.1.94 for now.

Fixes #10401
  • Loading branch information
ejona86 committed Jul 22, 2023
1 parent e179212 commit a77e1a2
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ grpc-netty version | netty-handler version | netty-tcnative-boringssl-static ver
1.50.x-1.53.x | 4.1.79.Final | 2.0.54.Final
1.54.x-1.55.x | 4.1.87.Final | 2.0.56.Final
1.56.x | 4.1.87.Final | 2.0.61.Final
1.57.x- | 4.1.94.Final | 2.0.61.Final
1.57.x- | 4.1.93.Final | 2.0.61.Final

_(grpc-netty-shaded avoids issues with keeping these versions in sync.)_

Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ googleauth = "1.4.0"
#
# Allowed to be different from guava-jre.
guava = '32.0.1-android'
netty = '4.1.94.Final'
netty = '4.1.93.Final'
# Keep the following references of tcnative version in sync whenever it's updated:
# SECURITY.md
nettytcnative = '2.0.61.Final'
Expand Down
24 changes: 12 additions & 12 deletions repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,20 @@ IO_GRPC_GRPC_JAVA_ARTIFACTS = [
"com.google.truth:truth:1.1.5",
"com.squareup.okhttp:okhttp:2.7.5",
"com.squareup.okio:okio:2.10.0",
"io.netty:netty-buffer:4.1.94.Final",
"io.netty:netty-codec-http2:4.1.94.Final",
"io.netty:netty-codec-http:4.1.94.Final",
"io.netty:netty-codec-socks:4.1.94.Final",
"io.netty:netty-codec:4.1.94.Final",
"io.netty:netty-common:4.1.94.Final",
"io.netty:netty-handler-proxy:4.1.94.Final",
"io.netty:netty-handler:4.1.94.Final",
"io.netty:netty-resolver:4.1.94.Final",
"io.netty:netty-buffer:4.1.93.Final",
"io.netty:netty-codec-http2:4.1.93.Final",
"io.netty:netty-codec-http:4.1.93.Final",
"io.netty:netty-codec-socks:4.1.93.Final",
"io.netty:netty-codec:4.1.93.Final",
"io.netty:netty-common:4.1.93.Final",
"io.netty:netty-handler-proxy:4.1.93.Final",
"io.netty:netty-handler:4.1.93.Final",
"io.netty:netty-resolver:4.1.93.Final",
"io.netty:netty-tcnative-boringssl-static:2.0.61.Final",
"io.netty:netty-tcnative-classes:2.0.61.Final",
"io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final",
"io.netty:netty-transport-native-unix-common:4.1.94.Final",
"io.netty:netty-transport:4.1.94.Final",
"io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.93.Final",
"io.netty:netty-transport-native-unix-common:4.1.93.Final",
"io.netty:netty-transport:4.1.93.Final",
"io.opencensus:opencensus-api:0.31.0",
"io.opencensus:opencensus-contrib-grpc-metrics:0.31.0",
"io.perfmark:perfmark-api:0.26.0",
Expand Down

0 comments on commit a77e1a2

Please sign in to comment.