addressed review comments

grpc · Apr 26, 2024 · 677f82c · 677f82c
1 parent 7167dcb
commit 677f82c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/api/src/main/java/io/grpc/DoubleCounterMetricInstrument.java b/api/src/main/java/io/grpc/DoubleCounterMetricInstrument.java
@@ -23,7 +23,7 @@
  */
 @Internal
 public final class DoubleCounterMetricInstrument extends PartialMetricInstrument {
-  public DoubleCounterMetricInstrument(int index, String name, String description, String unit,
+  DoubleCounterMetricInstrument(int index, String name, String description, String unit,
       List<String> requiredLabelKeys, List<String> optionalLabelKeys, boolean enableByDefault) {
     super(index, name, description, unit, requiredLabelKeys, optionalLabelKeys, enableByDefault);
   }

diff --git a/api/src/main/java/io/grpc/DoubleHistogramMetricInstrument.java b/api/src/main/java/io/grpc/DoubleHistogramMetricInstrument.java
@@ -25,7 +25,7 @@
 public final class DoubleHistogramMetricInstrument extends PartialMetricInstrument {
   private final List<Double> bucketBoundaries;
 
-  public DoubleHistogramMetricInstrument(int index, String name, String description, String unit,
+  DoubleHistogramMetricInstrument(int index, String name, String description, String unit,
       List<Double> bucketBoundaries, List<String> requiredLabelKeys, List<String> optionalLabelKeys,
       boolean enableByDefault) {
     super(index, name, description, unit, requiredLabelKeys, optionalLabelKeys, enableByDefault);

diff --git a/api/src/main/java/io/grpc/LongCounterMetricInstrument.java b/api/src/main/java/io/grpc/LongCounterMetricInstrument.java
@@ -23,7 +23,7 @@
  */
 @Internal
 public final class LongCounterMetricInstrument extends PartialMetricInstrument {
-  public LongCounterMetricInstrument(int index, String name, String description, String unit,
+  LongCounterMetricInstrument(int index, String name, String description, String unit,
       List<String> requiredLabelKeys, List<String> optionalLabelKeys, boolean enableByDefault) {
     super(index, name, description, unit, requiredLabelKeys, optionalLabelKeys, enableByDefault);
   }

diff --git a/api/src/main/java/io/grpc/LongGaugeMetricInstrument.java b/api/src/main/java/io/grpc/LongGaugeMetricInstrument.java
@@ -23,7 +23,7 @@
  */
 @Internal
 public final class LongGaugeMetricInstrument extends PartialMetricInstrument {
-  public LongGaugeMetricInstrument(int index, String name, String description, String unit,
+  LongGaugeMetricInstrument(int index, String name, String description, String unit,
       List<String> requiredLabelKeys, List<String> optionalLabelKeys, boolean enableByDefault) {
     super(index, name, description, unit, requiredLabelKeys, optionalLabelKeys, enableByDefault);
   }

diff --git a/api/src/main/java/io/grpc/LongHistogramMetricInstrument.java b/api/src/main/java/io/grpc/LongHistogramMetricInstrument.java
@@ -25,7 +25,7 @@
 public final class LongHistogramMetricInstrument extends PartialMetricInstrument {
   private final List<Long> bucketBoundaries;
 
-  public LongHistogramMetricInstrument(int index, String name, String description, String unit,
+  LongHistogramMetricInstrument(int index, String name, String description, String unit,
       List<Long> bucketBoundaries, List<String> requiredLabelKeys, List<String> optionalLabelKeys,
       boolean enableByDefault) {
     super(index, name, description, unit, requiredLabelKeys, optionalLabelKeys, enableByDefault);

diff --git a/api/src/main/java/io/grpc/MetricInstrumentRegistry.java b/api/src/main/java/io/grpc/MetricInstrumentRegistry.java
@@ -33,19 +33,20 @@
  */
 @Internal
 public final class MetricInstrumentRegistry {
-  public static final int INITIAL_INSTRUMENT_CAPACITY = 5;
+  static final int INITIAL_INSTRUMENT_CAPACITY = 5;
   private static MetricInstrumentRegistry instance;
   private final Object lock = new Object();
   private final Set<String> registeredMetricNames;
   private volatile MetricInstrument[] metricInstruments;
-  private volatile int instrumentListCapacity = INITIAL_INSTRUMENT_CAPACITY;
+  private volatile int instrumentListCapacity;
   @GuardedBy("lock")
   private int nextAvailableMetricIndex;
 
   @VisibleForTesting
   MetricInstrumentRegistry() {
     this.metricInstruments = new MetricInstrument[INITIAL_INSTRUMENT_CAPACITY];
     this.registeredMetricNames = new HashSet<>();
+    this.instrumentListCapacity = metricInstruments.length;
   }
 
   /**