*: Limit calls to pretty.ToJSON to more verbose debugging, warnings, and errors to improve performance
#7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and errors to improve performance.
aranjans
added
fixit
Type: Behavior Change
|
LGTM! @zasweq can you also please have a pass through this PR? |
zasweq
approved these changes
Apr 30, 2024
| @@ -194,5 +194,7 @@ func (ccr *ccResolverWrapper) addChannelzTraceEvent(s resolver.State) { | |||
| } else if len(ccr.curState.Addresses) == 0 && len(s.Addresses) > 0 { | |||
| updates = append(updates, "resolver returned new addresses") | |||
| } | |||
| channelz.Infof(logger, ccr.cc.channelz, "Resolver state updated: %s (%v)", pretty.ToJSON(s), strings.Join(updates, "; ")) | |||
| if channelz.IsOn() || logger.V(2) { | |||
There was a problem hiding this comment.
What is the reason for the additional channelz.IsOn() bool conditional?
There was a problem hiding this comment.
It's similar to the reason for the logger.V(2) check. We only want to call pretty.ToJSON when we know we're going to use the result. channelz.Infof can add a trace event, log, or both, so we want to call it when channelz data collection is on, we're logging at depth 2, or both.
aranjans
approved these changes
Apr 30, 2024
|
Please don't merge this yet. Doug Fawley and I are still discussing this approach. |
|
I'm going to close this since I think we got the same win just from the Debugf calls. We can reopen or recreate in the future if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: None