Add lazyDebugf method to process the arguments lazily #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Apr 23, 2024
| @@ -79,6 +79,34 @@ func (pl *PrefixLogger) Debugf(format string, args ...any) { | |||
|
|
|||
| } | |||
|
|
|||
| // LazyDebugf does info logging at verbose level 2, only | |||
| // evaluating arguments if logging is enabled. | |||
| func (pl *PrefixLogger) LazyDebugf(format string, args ...func() any) { | |||
There was a problem hiding this comment.
Is this worth it?
This makes the call site:
logger.LazyDebugf("blah %s %s %v", func() { blah1() }, func() { blah2() }, func() { blah3() })vs.
if logger.V(2) {
logger.Infof("blah %s %s %v", blah1(), blah2(), blah3())
}Yes it's "3 lines instead of 1 line" but:
- it's not obvious that Debugf is checking V(2), and
- the usage with Lazy is really hard to read and very long because of all the extraneous closures.
I think I'd rather just delete Debugf instead.
There was a problem hiding this comment.
How many occurrences of Debugf do we have?
|
Taking pause on this sometime to prioritize other issues. Will update this PR based on this comment |
|
Let's close this PR for now and re-open when we are actively working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7154
RELEASE NOTES: