advancedtls: Rename RevocationConfig #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtcooke94
added
Type: Internal Cleanup
erm-g
reviewed
Apr 23, 2024
security/advancedtls/crl.go
Outdated
| @@ -55,8 +55,9 @@ type Cache interface { | |||
| Get(key any) (value any, ok bool) | |||
| } | |||
|
|
|||
| // RevocationConfig contains options for CRL lookup. | |||
| type RevocationConfig struct { | |||
| // RevocationOptions allows a user to configure revocation using certificate | |||
There was a problem hiding this comment.
I'd word it like 'RevocationOptions allows users to configure certification revocation behavior' - WDYT?
There was a problem hiding this comment.
I like that more, changed
erm-g
approved these changes
Apr 25, 2024
arvindbr8
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
RevocationConfigtoRevocationOptionsto match the naming of all of our otherOptionsstructs. A type alias remains as to not break existing code.RELEASE NOTES: none