Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ErrNoSubConnAvailable reason to pick ctx timeout #7143

Closed
wants to merge 3 commits into from

correct the incorrect edits of picker test

dc6f6b6
Select commit
Failed to load commit list.
Closed

add ErrNoSubConnAvailable reason to pick ctx timeout #7143

correct the incorrect edits of picker test
dc6f6b6
Select commit
Failed to load commit list.
Mergeable / Mergeable failed Apr 30, 2024 in 0s

1/3 Fail(s): DESCRIPTION

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: LABEL

  • ✔️ label must include '^Type:'
    Input : P2,Status: Requires Reporter Clarification,Type: Bug
    Settings : {"must_include":{"regex":"^Type:"}}

❌ Validator: DESCRIPTION

  • description does not include "^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$"**
    Input : If the server-side balancer picks balancer.ErrNoSubConnAvailable, the gRPC picking logic will cause the context (ctx) to block until it times out. As a result, from the client's perspective, it appears as if there is a server response timeout, without knowing that it is due to NoSubConnAvailable.

#7135
Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

✔️ Validator: MILESTONE

  • ✔️ milestone must include 'Release$'
    Input : 1.64 Release
    Settings : {"must_include":{"regex":"Release$"}}