peer and metadata: Implement the Stringer interface for Peer and Metadata #7137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
force-pushed
the
master
branch
2 times, most recently
from
bc88d17
to
5e7b8a3
Compare
aranjans
suggested changes
Apr 19, 2024
AnomalRoil
force-pushed
the
master
branch
2 times, most recently
from
45c73d2
to
cfa61fb
Compare
AnomalRoil
commented
Apr 22, 2024
AnomalRoil
force-pushed
the
master
branch
2 times, most recently
from
5563de4
to
4ab12a3
Compare
Effectively allowing to print context containing Peers properly Also enabling logging of Metadata in an easier way RELEASE NOTES: - peer/peer: implement the Stringer interface for pretty-printing Peers - metadata/metadata: implement the Stringer interface for pretty printing metadata Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
…fication of which SubConn is used Protect access to curAddr with ac.mutex Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
…n identification of which SubConn is used" This reverts commit 001f394. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
arvindbr8
requested changes
Apr 24, 2024
arvindbr8
requested changes
Apr 24, 2024
aranjans
added
the
Type: Behavior Change
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
arvindbr8
requested changes
May 1, 2024
AnomalRoil
commented
May 2, 2024
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
arvindbr8
reviewed
May 2, 2024
| want string | ||
| }{ | ||
| { | ||
| name: "+Addr-LocalAddr+ValidAuth", |
There was a problem hiding this comment.
Just FYI, go test std library already does something similar by replacing \ss with _s.
There was a problem hiding this comment.
I was trying to convey information about whether the test case included + or didn't include - that specific field.
arvindbr8
approved these changes
May 2, 2024
|
Per policy we need one more review before we can check this in. I will ping a co-maintainer to take a look at this. |
zasweq
approved these changes
May 6, 2024
zasweq
changed the title
zasweq
changed the title
zasweq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively allowing to print contextes containing a
Peerproperly.Instead of printing with
%vas:contexts containing a peer will now print as:
This is also satisfying Stringer interface for
Metadata, allowing to print them easily too. SinceMetadataare basically a map, notice thatStringoutput is not stable. I could change it to print it in alphabetical order if you prefer.RELEASE NOTES: