New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: improve regenerate.sh to use the correct proto compiler version #7064
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7064 +/- ##
==========================================
- Coverage 81.24% 80.70% -0.54%
==========================================
Files 345 346 +1
Lines 33941 33802 -139
==========================================
- Hits 27574 27280 -294
- Misses 5202 5355 +153
- Partials 1165 1167 +2 |
8bb8747
to
af6bc49
Compare
e404049
to
a582a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we didnt track the version of protoc in different places.
What might be nicer is if both regenerate.sh
and vet.sh
points to the same place to install protoc. Also note ./vet.sh -install
basically does the same thing of installing protoc
for Github Actions.
I prefer creating a new script which installs protoc based on the ${OS}
. And for ./vet -install
I could call into the script to install the linux
and x86_64
flavor of protoc. And do something similar for regenerate.sh
20c21cb
to
a880e4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few comments on your change. Could you please take a look at it?
2cddfeb
to
cc78601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments from the previous pass still seems to be unaddressed:
- https://github.com/grpc/grpc-go/pull/7064/files#r1569226189
- https://github.com/grpc/grpc-go/pull/7064/files#r1569224986
I also have some more comments. I think it looks overall okay if the aim is to fix the current issue. But could you please open a new issue which talks about the TODOs from this PR?
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
fyi: was caught up in other issues. I am working on this right now on priority, will update the PR soon. |
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
@arvindbr8 In contrast to this comment, first comment is resolved but i didn't understand the second one. Can you be more specific on that? |
Fixes #6583
RELEASE NOTES: n/a