Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer: cleanup of deprecated ClientConn.Target() #5855

Closed
wants to merge 2 commits into from

Conversation

ramil600
Copy link

@ramil600 ramil600 commented Dec 10, 2022

use Target field in the BuildOptions instead.

RELEASE NOTES: none

use Target field in the BuilOptions instead.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ramil600 / name: Ramil Mirhasanov (56696eb)

@ramil600 ramil600 changed the title balancer : cleanup of deprecated ClientConn.Target() balancer: cleanup of deprecated ClientConn.Target() Dec 10, 2022
@easwars
Copy link
Contributor

easwars commented Dec 15, 2022

This is not the change we want to make. Please see #5852.

@easwars easwars closed this Dec 15, 2022
@easwars
Copy link
Contributor

easwars commented Dec 15, 2022

@ramil600 : Please do talk to us before spending time and effort working on any open issues on our repo. Discussing possible solutions with us before starting to work on them would be beneficial for both of us. Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants