Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(example): Remove import duplication #5760

Closed
wants to merge 1 commit into from
Closed

feat(example): Remove import duplication #5760

wants to merge 1 commit into from

Conversation

linhbkhn95
Copy link

@linhbkhn95 linhbkhn95 commented Nov 2, 2022 •
edited

Why did we need it?

  • Remove import duplication

Concern?

  • if it is author's intent which separate two things
    • grpc's service definition
    • grpc's dto

@linux-foundation-easycla
Copy link

CLA Not Signed

@linhbkhn95 linhbkhn95 changed the title feat(*): Remove import duplication feat(example): Remove import duplication Nov 2, 2022
@holdno
Copy link
Contributor

holdno commented Nov 2, 2022

#5466

@linhbkhn95
Copy link
Author

I got it, let me close this PR

@linhbkhn95 linhbkhn95 closed this Nov 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@linhbkhn95 @holdno