New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport: new stream with actual server name #5748
Merged
dfawley
merged 10 commits into
grpc:master
from
holdno:feat/NewStreamWithActualServerName
Nov 18, 2022
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
40ec788
transport: new stream with actual server name
holdno 2b12d75
renamed and add test for: transport: ensure value of :authority heade…
holdno 95a427b
fix: copy callHdr to resolve race
holdno 4cbfed1
remove and modify valueless comments
holdno 6f29d4e
move resolver authority test to e2e test
holdno acdbf62
restore transport/transport_test.go
holdno 56e5899
modify test notes
holdno 3d99b17
fix: undefined resolver
holdno 86b897f
modify test notes
holdno 223845f
avoid redundant copying
holdno File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfawley : I asked @holdno to make this copy here, because I wasn't completely sure of the downstream effects of changing the
CallHdr.Host
field. Could you please take a look. Thanks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's the right call; otherwise if you reuse
callHdr
across multiple attempts for one RPC, and one transport has an authority set and another doesn't, then you could end up with the wrong behavior.Can we avoid making this copy, though, if there is no change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your advice, it looks better.