Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: expose API to set send compressor #5744

Merged
merged 13 commits into from Jan 31, 2023
Merged

server: expose API to set send compressor #5744

merged 13 commits into from Jan 31, 2023

Commits on Oct 26, 2022

  1. server: expose API to set send compressor

    @jronak
    jronak committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b19a201 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. address comments

    @jronak
    jronak committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6d03a48 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Split tests into multiple functions 

    Address nits across naming and test assertions

Update method doc on setSendCompressor
    @jronak
    jronak committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3dfdd22 View commit details
    Browse the repository at this point in the history

  2. Fix lint errors due to t.Fatal usage 

    Vet complains when t.Fatal is used in non-test goroutine
```
Error: internal/transport/handler_server_test.go:299:21: call to (*T).Fatal from a non-test goroutine
```
    @jronak
    jronak committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    805e90e View commit details
    Browse the repository at this point in the history

  3. Nit: rename test name and update comment

    @jronak
    jronak committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    52bc0e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Refactor tests

    @jronak
    jronak committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1de5f58 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. address comments

    @jronak
    jronak committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e7fc4fc View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Rename non-internal ClientAdvertisedCompressors to ClientSupportedCom… 

    …pressors

Fix documentation nits
    @jronak
    jronak committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    de76817 View commit details
    Browse the repository at this point in the history

  2. Ignore empty grpc-accept-encoding header

    @jronak
    jronak committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3e07c8f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. update test to assert compressor invokes

    @jronak
    jronak committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    6297002 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. fix test var name

    @jronak
    jronak committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    cedc506 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into set-send-compressor

    @jronak
    jronak committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3db83b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. add test comment

    @jronak
    jronak committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c52a550 View commit details
    Browse the repository at this point in the history