xds/resolver: generate channel ID randomly #5591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Aug 19, 2022
| // Hash the ClientConn pointer which logically uniquely | ||
| // identifies the client. | ||
| policyHash = xxhash.Sum64String(fmt.Sprintf("%p", &cs.r.cc)) | ||
| policyHash = cs.r.clientID |
There was a problem hiding this comment.
Update HashPolicyTypeChannelID's comment please.
| @@ -184,6 +186,9 @@ type xdsResolver struct { | |||
| activeClusters map[string]*clusterInfo | |||
|
|
|||
| curConfigSelector *configSelector | |||
|
|
|||
| // A random number which uniquely identifies this client. | |||
| clientID uint64 | |||
There was a problem hiding this comment.
Switch to channelID? Also comment feels weird, "this client" in a resolver. I know the Client Conn owns this resolver with a 1:1 cardinality but this comment feels weird.
There was a problem hiding this comment.
Switched. Not sure about "feels weird" or how to resolve that, but I changed the comment a bit. In the future please be more specific about what's wrong and/or how you would fix it.
There was a problem hiding this comment.
Yeah sorry I meant this client is in reference to what? Your comment change works for me.
|
Still LGTM, go ahead and merge. |
dfawley
changed the title
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change keeps our code in sync with the spec change at grpc/proposal#320. We would rather generate a purely random number for this identifier to ensure different clients are extremely unlikely to generate the same identifier.
cc @apolcyn
RELEASE NOTES: none