xds: Fixed GoLang regression for Outlier Detection #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Jul 25, 2022
sergiitk
approved these changes
Jul 25, 2022
zasweq
added a commit
to zasweq/grpc-go
that referenced
this pull request
Jul 26, 2022
xds: Fixed GoLang regression for Outlier Detection
zasweq
added a commit
that referenced
this pull request
Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in Outlier Detection, when Outlier Detection was set to true the configuration would be prepared which would try and Build a placeholder balancer which would fail RPC's. This hardcodes the Environment Variable configuration to false, which will be changed when my full Outlier Detection PR gets merged. This will need to get backported to 1.48, as the bug is present in that branch too.
RELEASE NOTES: