Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: return better status for context err when writing header #5292

Merged
merged 6 commits into from Apr 8, 2022
Merged

server: return better status for context err when writing header #5292

merged 6 commits into from Apr 8, 2022

Commits on Apr 5, 2022

  1. Handle ctx err in writeheader

    @idiamond-stripe
    idiamond-stripe committed Apr 5, 2022
    Copy the full SHA
    1715f7e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. handle ContextErr inside WriteHeader

    @idiamond-stripe
    idiamond-stripe committed Apr 6, 2022
    Copy the full SHA
    6f33edb View commit details
    Browse the repository at this point in the history

  2. always return status.Error from WriteHeader

    @idiamond-stripe
    idiamond-stripe committed Apr 6, 2022
    Copy the full SHA
    e38bde5 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. respond to review feedback

    @idiamond-stripe
    idiamond-stripe committed Apr 7, 2022
    Copy the full SHA
    732ffc9 View commit details
    Browse the repository at this point in the history

  2. replace internal error with convert

    @idiamond-stripe
    idiamond-stripe committed Apr 7, 2022
    Copy the full SHA
    f739f9e View commit details
    Browse the repository at this point in the history

  3. move s.cancel and remove TODO

    @idiamond-stripe
    idiamond-stripe committed Apr 7, 2022
    Copy the full SHA
    32d8958 View commit details
    Browse the repository at this point in the history