binarylog: generalize binarylog's MethodLogger preparing for new observability features #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menghanl PTAL. I have updated the interface as suggested. Now, the LOC in internal binarylog is reduced to +37-20 (from >100). |
menghanl
approved these changes
Mar 17, 2022
|
@dfawley PTAL. |
dfawley
approved these changes
Mar 21, 2022
|
(Feel free to merge, I don't have write access) |
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, we want to utilize the pre-existing state-storing object
MethodLoggerfor gRPC Observability. This object has the same life span as each RPC, and we can conveniently store extra context information about the RPC in it to generate better logs.Child PR: #5196
RELEASE NOTES: N/A