Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflection: improve server implementation #5197

Merged
merged 6 commits into from Feb 18, 2022
Merged

reflection: improve server implementation #5197

merged 6 commits into from Feb 18, 2022

Commits on Feb 16, 2022

  1. improve server reflection 

    1. Support alternate source of descriptors, like for RPC servers that get
   their descriptors dynamically and are dynamic proxies
2. Use the new protobuf API v2 stuff to get the descriptors, which is much
   more sane than the old APIs
    @jhump
    jhump committed Feb 16, 2022
    Copy the full SHA
    743e65d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. review feedback; use single interface for source of service names; tw… 

    …eak Go docs
    @jhump
    jhump committed Feb 17, 2022
    Copy the full SHA
    5999441 View commit details
    Browse the repository at this point in the history

  2. review feedback: mark new stuff as experimental; prefer Register; rem… 

    …ove ServiceInfoFromNames
    @jhump
    jhump committed Feb 17, 2022
    Copy the full SHA
    0588e9b View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. no need for sync.Once

    @jhump
    jhump committed Feb 18, 2022
    Copy the full SHA
    a97ada8 View commit details
    Browse the repository at this point in the history

  2. review comments: more tweaks to comments; label all other added expor… 

    …ted symbols as experimental
    @jhump
    jhump committed Feb 18, 2022
    Copy the full SHA
    281c819 View commit details
    Browse the repository at this point in the history

  3. reorder elements: preferred exported symbols, then experimental stuff… 

    … (the newly added stuff), then the unexported server impl
    @jhump
    jhump committed Feb 18, 2022
    Copy the full SHA
    505fb99 View commit details
    Browse the repository at this point in the history