Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp/observability: implement logging via binarylog #5196

Merged
merged 23 commits into from Apr 6, 2022
Merged

gcp/observability: implement logging via binarylog #5196

merged 23 commits into from Apr 6, 2022

Commits on Apr 5, 2022

  1. feat: implement grpc-observability logging via binarylog 

    * Includes generalized MethodConfig
* Includes updated config definition
* Includes custom tags and location tags
    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    af191b0 View commit details
    Browse the repository at this point in the history

  2. Adopt reviewer's advices

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    c54d46e View commit details
    Browse the repository at this point in the history

  3. Add additional comment for test cases

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    a518a77 View commit details
    Browse the repository at this point in the history

  4. Address reviewer's comments

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    ca1f842 View commit details
    Browse the repository at this point in the history

  5. Redo the filter logic

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    7478646 View commit details
    Browse the repository at this point in the history

  6. Add a test case for filters' priority

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    13f8ebc View commit details
    Browse the repository at this point in the history

  7. Fix the internal binarylog unit tests

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    e034f24 View commit details
    Browse the repository at this point in the history

  8. Make vet.sh happy

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    da1a378 View commit details
    Browse the repository at this point in the history

  9. Don't expose internal struct

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    229534d View commit details
    Browse the repository at this point in the history

  10. Address reviewer's comments

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    97c9aad View commit details
    Browse the repository at this point in the history

  11. Resolve one more missed comment

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    4672b81 View commit details
    Browse the repository at this point in the history

  12. Separate validation and matching of patterns && 2 more test cases

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    4d04d3d View commit details
    Browse the repository at this point in the history

  13. Add stricter config check && address other comments

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    38dbab5 View commit details
    Browse the repository at this point in the history

  14. Update the logic of deciding priorities for log_filters

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    74b5a2f View commit details
    Browse the repository at this point in the history

  15. Produce more granular warning for method logger config

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    2efb72b View commit details
    Browse the repository at this point in the history

  16. Address reviewer's comments

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    8df1c14 View commit details
    Browse the repository at this point in the history

  17. Try to combine 2 errors if needed

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    8ab5e44 View commit details
    Browse the repository at this point in the history

  18. Move observability to gcp/observability

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    a7ea813 View commit details
    Browse the repository at this point in the history

  19. Update the go_package for proto files

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    c9205b9 View commit details
    Browse the repository at this point in the history

  20. Update go.mod for path change

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    7d58525 View commit details
    Browse the repository at this point in the history

  21. Make proto (I thought vet.sh will run it for me)

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    b2a4075 View commit details
    Browse the repository at this point in the history

  22. retrigger checks

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    00cda05 View commit details
    Browse the repository at this point in the history

  23. the 1.18 test is flaky

    @lidizheng
    lidizheng committed Apr 5, 2022
    Copy the full SHA
    f87acae View commit details
    Browse the repository at this point in the history