Commits on Feb 1, 2022

1. Support xDS credentials plugin. …

   Currently the credentials used for communication with the xDS management
   server is restricted to "google_default" and "insecure". There is no way
   for users to inject custom credentials, even though the bootstrap can be
   used to pass in different values.
   
   This PR adds support for a new credentials package which can be used to
   register supported credentials along with a name that can be recognized
   by the bootstrap.
   
   The credential package also registers the currently supported
   "google_default" and "insecure" options to maintain the status quo. To keep the
   interface of the credentials builder clean, the insecure credentials now
   satisfies the grpc credentials bundle interface.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   6a1259c View commit details

   Browse the repository at this point in the history

2. Remove the blank line after the comment and the package statement.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   1e6e23b View commit details

   Browse the repository at this point in the history

3. Remove blank line from Builder interface

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   5f60e4b View commit details

   Browse the repository at this point in the history

4. Use "Get" as the getter name to be consistent with current …

   registry implementations.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   9808f0c View commit details

   Browse the repository at this point in the history

5. Add method to return name associated with registered builder

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   b4f79bc View commit details

   Browse the repository at this point in the history

6. Allow credentials builder to return error due to JSON config issues.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   116361c View commit details

   Browse the repository at this point in the history

7. Move the credentials registry into bootstrap, delete previously added …

   xds/credentials/*.go. Also add the relevant builders in the google creds
   package.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   da005ea View commit details

   Browse the repository at this point in the history

8. Fix comment header for RegisterCredentials

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   3007940 View commit details

   Browse the repository at this point in the history

9. Move the packages around for better organization as per the suggestions. …

   1. New bootstrap package that users can use.
   2. Move insecure creds builder to google/creds.
   3. Move registration to google/ and google/insecure.

   

   anicr7 committed Feb 1, 2022
   Copy the full SHA

   497bec3 View commit details

   Browse the repository at this point in the history

10. Don't export creds builders. Remove google/insecure and use …

    credential/insecure instead.
    
    Don't use google/insecure in bootstrap.go as it leads to cyclic
    dependencies.

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    1a5ce53 View commit details

    Browse the repository at this point in the history

11. Add experimental labels around xds/bootstrap package

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    2a95e62 View commit details

    Browse the repository at this point in the history

12. Move the CredsBuilders and registration back to internal/bootstrap.go.

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    0c1de51 View commit details

    Browse the repository at this point in the history

13. Separate GetCredentials and Build.

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    0251470 View commit details

    Browse the repository at this point in the history

14. Fix comment for googleDefaultCredsBuilder

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    b132d05 View commit details

    Browse the repository at this point in the history

15. Add else statement warning about non registered creds

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    c4dcabf View commit details

    Browse the repository at this point in the history

16. Simplify unit tests

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    e83cb32 View commit details

    Browse the repository at this point in the history

17. Remove warning log when credential is not registered

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    f72d3db View commit details

    Browse the repository at this point in the history

18. Address review comments.

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    a7eae17 View commit details

    Browse the repository at this point in the history

19. Combine couple of if conditions

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    990f2f4 View commit details

    Browse the repository at this point in the history

20. Use consts in unit tests

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    362d1e0 View commit details

    Browse the repository at this point in the history

21. Revert comments from creds back to credentials. Also change insecureB… …

    …undle() to return new transport credentials again

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    37ea507 View commit details

    Browse the repository at this point in the history

22. Change log warning to returning an error instead, when building bundl… …

    …e fails due to JSON parsing

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    711c075 View commit details

    Browse the repository at this point in the history

23. Remove extra comments and fix one comment to use credential instead o… …

    …f builder

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    256872a View commit details

    Browse the repository at this point in the history

24. Move initialization to global context

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    1fa6ba1 View commit details

    Browse the repository at this point in the history

25. Remove error tag from the error message

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    7685e5f View commit details

    Browse the repository at this point in the history

26. Remove _ for single parameter functions

    

    anicr7 committed Feb 1, 2022
    Copy the full SHA

    9895c8c View commit details

    Browse the repository at this point in the history