Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: use insecure.NewCredentials() instead of grpc.WithInsecure() #5087

Merged
merged 1 commit into from Jan 12, 2022
Merged

examples: use insecure.NewCredentials() instead of grpc.WithInsecure() #5087

merged 1 commit into from Jan 12, 2022

Conversation

TiraTom
Copy link
Contributor

@TiraTom TiraTom commented Dec 25, 2021 •
edited

Current document asks to replace WithInsecure() with insecure.NewCredentials(), so I updated example code.

cf) #5068

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 25, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@easwars easwars changed the title minor improvement on example code: use insecure.NewCredentials() instead of grpc.WithInsecure examples: use insecure.NewCredentials() instead of grpc.WithInsecure() Dec 30, 2021
@easwars easwars added the Type: Documentation Documentation or examples label Dec 30, 2021
@easwars easwars added this to the 1.44 Release milestone Dec 30, 2021
@zasweq zasweq modified the milestones: 1.44 Release, 1.45 Release Jan 11, 2022
@zasweq zasweq merged commit 0145b50 into grpc:master Jan 12, 2022
@TiraTom TiraTom deleted the use-insecure-NewCredentials-instead-of-grpc-WithInsecure branch January 13, 2022 21:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

@easwars easwars easwars approved these changes

@HeCorr HeCorr HeCorr approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TiraTom @menghanl @easwars @HeCorr @zasweq