Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrr: improve randomWRR performance #5067
wrr: improve randomWRR performance #5067
Changes from 6 commits
bdd88ac
f2009a0
b52eec9
8edbcca
88b9a1e
5c32a8d
4c8c3c7
144df07
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this may still fail if
sumOfWeights == 0
(this happens when the items added all are weight 0 🤷♂️ )Maybe keep the check
if sumOfWeights == 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If items added all are weight 0, then
rw.equalWeights
will be true,Next
will return normally at line 61return rw.items[grpcrandInt63n(int64(len(rw.items)))].item
I considered keeping
if sumOfWeights == 0 return nil
, but the behaviour will be different fromedf.go
, in edf, if allitem's weights are zero,
Next
will return non nil itemThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I now see what you meant in the old comments.
weight
is used once here.I would be OK to keep the weight field to simplify the code here.
Either way is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
weight
back toweightedItem
to simplify code hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, why
weight
type isint64
notuint32
,int64
will allow user add negative weight item toWRR
which will result undefined behaviour inNext
.