New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc_util: Change error message to indicate size after decompression #4918
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d80a732
rpc_util: Change error message to indicate size after decompression
uds5501 ed2a57a
Merge branch 'master' into fix-4761
uds5501 bedb598
rpc_util: Remove double checks for non compressed messages and change…
uds5501 367ee67
rpc_util: Fix vet errors
uds5501 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct. This is the raw message before decompression.
recvAndDecompress
calls this and decompresses this payload as a separate step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that we can't call this the "compressed" message, since we don't know whether it's compressed in the first place.
pf
can tell us whether it's compressed if we can't come up with a generic enough message to convey the idea properly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfawley
I have a small question, I was writing this fix after reading this comment here:
#4761 (comment)
In this, the issue creator says that he is "compressing" an
8 MB
message to4 MB
and then sending it over.Now, in our logic, since we are decompressing it, later on, is it possible that your current logic and error used are absolutely right and the message was not compressed in the first place?
If so, then this PR is irrelevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check the message size twice. Here (not yet decompressed) and here after decompressing:
grpc-go/rpc_util.go
Line 721 in 3b94303
And if a message isn't compressed, it seems like we might be checking the size twice, which we could clean up as part of this. The issue is about clarifying whether it's the compressed message or the decompressed message size was over the limit (if the message is compressed).