Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: validate metadata keys and values #4886

Merged
merged 26 commits into from Feb 23, 2022
Merged

metadata: validate metadata keys and values #4886

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6399d6e
add metadata validate function
Patrick0308 Oct 19, 2021
aec9260
add metadata validate unit test and fix key checker
Patrick0308 Oct 19, 2021
b6f263e
add validate add server stream and grpc.Invoke
Patrick0308 Nov 23, 2021
2520260
make TestValidate a table driven test
Patrick0308 Dec 1, 2021
8625b25
optimize for
Patrick0308 Dec 7, 2021
b848e9b
move Validate to internal.metadata
Patrick0308 Dec 8, 2021
99522c3
update log and unittest
Patrick0308 Dec 9, 2021
4b88571
not use pairs
Patrick0308 Dec 9, 2021
0ac1e02
move validate to newClientStream and update comment
Patrick0308 Dec 10, 2021
88ea32f
fix unit test
Patrick0308 Dec 13, 2021
84bbd64
format code
Patrick0308 Dec 14, 2021
bc980fb
ignore presudo header and add tests
Patrick0308 Dec 17, 2021
60aca70
fix problems
Patrick0308 Jan 7, 2022
82240b2
fix test problem
Patrick0308 Jan 7, 2022
4bee015
format code
Patrick0308 Jan 13, 2022
f04f60c
fix review problem
Patrick0308 Jan 16, 2022
a5d18dd
fix format
Patrick0308 Jan 16, 2022
cb062d0
delete useless import and fix tests
Patrick0308 Jan 19, 2022
fad092e
fix review problem
Patrick0308 Jan 20, 2022
9e3a801
fix tests problem
Patrick0308 Jan 24, 2022
4084375
fix problem
Patrick0308 Jan 24, 2022
145bef2
format code
Patrick0308 Jan 24, 2022
881ab45
update tests
Patrick0308 Jan 24, 2022
47c552d
fix review problem
Patrick0308 Feb 4, 2022
30b92a3
format
Patrick0308 Feb 22, 2022
6674adc
expect error log
Patrick0308 Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/metadata_test.go
View file
Open in desktop
Expand Up @@ -26,7 +26,6 @@ import (
"testing"
"time"

"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/internal/stubserver"
"google.golang.org/grpc/metadata"
Expand Down Expand Up @@ -74,7 +73,7 @@ func (s) TestInvalidMetadata(t *testing.T) {
return err
}
test := tests[testNum]
testNum = testNum + 1
testNum ++
Patrick0308 marked this conversation as resolved.
Show resolved Hide resolved
if err := stream.SetHeader(test.md); !reflect.DeepEqual(test.want, err) {
return fmt.Errorf("call stream.SendHeader(md) validate metadata which is %v got err :%v, want err :%v", test.md, err, test.want)
}
Expand Down Expand Up @@ -103,10 +102,11 @@ func (s) TestInvalidMetadata(t *testing.T) {
// call the stream server's api to drive the server-side unit testing
for _, test := range tests {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
stream, err := ss.Client.FullDuplexCall(ctx, grpc.WaitForReady(true))
stream, err := ss.Client.FullDuplexCall(ctx)
defer cancel()
if err != nil {
t.Errorf("call ss.Client.FullDuplexCall(context.Background()) will success but got err :%v", err)
Patrick0308 marked this conversation as resolved.
Show resolved Hide resolved
continue
}
if err := stream.Send(&testpb.StreamingOutputCallRequest{}); err != nil {
t.Errorf("call ss.Client stream Send(nil) will success but got err :%v", err)
Expand Down