Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: better RFC 3986 compliant target parsing #4817

Merged
merged 24 commits into from Oct 14, 2021
Merged

grpc: better RFC 3986 compliant target parsing #4817

merged 24 commits into from Oct 14, 2021

Commits on Sep 24, 2021

  1. grpc: increase compliance with RFC 3986 while parsing the dial target

    @easwars
    easwars committed Sep 24, 2021
    Copy the full SHA
    fb12d07 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. fix resolver in load_balancing example

    @easwars
    easwars committed Sep 27, 2021
    Copy the full SHA
    cee1b44 View commit details
    Browse the repository at this point in the history

  2. fix resolver in name_resolving example

    @easwars
    easwars committed Sep 27, 2021
    Copy the full SHA
    d19cd9b View commit details
    Browse the repository at this point in the history

  3. fix typo

    @easwars
    easwars committed Sep 27, 2021
    Copy the full SHA
    0d0c1a5 View commit details
    Browse the repository at this point in the history

  4. make unix target canonical in test

    @easwars
    easwars committed Sep 27, 2021
    Copy the full SHA
    c98608a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. add Unparsed field to resolver.Target

    @easwars
    easwars committed Sep 29, 2021
    Copy the full SHA
    fb4b9c0 View commit details
    Browse the repository at this point in the history

  2. make getServerName a method on cc instead of ac

    @easwars
    easwars committed Sep 29, 2021
    Copy the full SHA
    2750421 View commit details
    Browse the repository at this point in the history

  3. some comments

    @easwars
    easwars committed Sep 29, 2021
    Copy the full SHA
    c522792 View commit details
    Browse the repository at this point in the history

  4. use passthrough whenever custom dialer is used

    @easwars
    easwars committed Sep 29, 2021
    Copy the full SHA
    4f56e2e View commit details
    Browse the repository at this point in the history

  5. resolver builder

    @easwars
    easwars committed Sep 29, 2021
    Copy the full SHA
    ae490d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. strip leading "/" from endpoint for backward compatibility

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    99fdc43 View commit details
    Browse the repository at this point in the history

  2. moved these tests to clientconn_parsed_target_test.go

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    f578ae5 View commit details
    Browse the repository at this point in the history

  3. revert unwanted import change

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    1fa26dc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into url_parse_attempt_3

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    7936989 View commit details
    Browse the repository at this point in the history

  5. update comment for ParsedURL

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    499f603 View commit details
    Browse the repository at this point in the history

  6. add tests for scheme:absolute-path

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    c5c4383 View commit details
    Browse the repository at this point in the history

  7. return error if ParsedURL is nil in unix resolver

    @easwars
    easwars committed Sep 30, 2021
    Copy the full SHA
    5cff707 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. store the parsed url by value in resolver.Target

    @easwars
    easwars committed Oct 1, 2021
    Copy the full SHA
    c36957f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. review comments

    @easwars
    easwars committed Oct 7, 2021
    Copy the full SHA
    8546581 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. review comments 

    - make determineAuthority() a func instead of a method on ClientConn
- return error from Dial() if authority from creds and dialOption do not
  match
- simplify
    @easwars
    easwars committed Oct 11, 2021
    Copy the full SHA
    78fcb25 View commit details
    Browse the repository at this point in the history

  2. edit todo for optional resolver interface

    @easwars
    easwars committed Oct 11, 2021
    Copy the full SHA
    4fb05c3 View commit details
    Browse the repository at this point in the history

  3. ClientHandshake comments

    @easwars
    easwars committed Oct 11, 2021
    Copy the full SHA
    c6057e5 View commit details
    Browse the repository at this point in the history

  4. deprecate old fields of resolver.Target and rename ParsedURL to URL

    @easwars
    easwars committed Oct 11, 2021
    Copy the full SHA
    f230c53 View commit details
    Browse the repository at this point in the history

  5. validate parsed URL in unit tests

    @easwars
    easwars committed Oct 11, 2021
    Copy the full SHA
    5f96946 View commit details
    Browse the repository at this point in the history