Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authz: create interceptors for gRPC security policy API #4664

Merged
merged 14 commits into from Sep 2, 2021
Merged

authz: create interceptors for gRPC security policy API #4664

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
14c76f7
Static Authorization Interceptor
ashithasantosh Aug 11, 2021
a5ee344
Use TestService in end2end tests.
ashithasantosh Aug 17, 2021
6fd1ead
test fixes
ashithasantosh Aug 18, 2021
8feabc1
Resolving comments.
ashithasantosh Aug 24, 2021
1332c85
Debugging Streaming call error
ashithasantosh Aug 25, 2021
89848a1
Using single context.
ashithasantosh Aug 25, 2021
3ca35f8
Adding comments to test.
ashithasantosh Aug 25, 2021
49de13b
Adds check for nil error
ashithasantosh Aug 25, 2021
6a2839e
Resolving comments.
ashithasantosh Aug 26, 2021
61a51d7
Change status code to internal.
ashithasantosh Aug 27, 2021
15829b2
Add deadline to context.
ashithasantosh Aug 27, 2021
6385ef2
Log error on missing fields in context.
ashithasantosh Sep 1, 2021
6da894d
Check for eof in stream.Send. Expected when server returns error.
ashithasantosh Sep 1, 2021
5b5db7c
Update logs.
ashithasantosh Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion authz/sdk_end2end_test.go
View file
Open in desktop
Expand Up @@ -295,7 +295,7 @@ func TestSDKEnd2End(t *testing.T) {
Body: []byte("hi"),
},
}
if err := stream.Send(req); err != nil {
if err := stream.Send(req); err != nil && err != io.EOF {
t.Fatalf("failed stream.Send err: %v", err)
}
_, err = stream.CloseAndRecv()
Expand Down
4 changes: 4 additions & 0 deletions internal/xds/rbac/rbac_engine.go
View file
Open in desktop
Expand Up @@ -32,12 +32,15 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/grpclog"
"google.golang.org/grpc/internal/transport"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/peer"
"google.golang.org/grpc/status"
)

var logger = grpclog.Component("rbac")

var getConnection = transport.GetConnection

// ChainEngine represents a chain of RBAC Engines, used to make authorization
Expand Down Expand Up @@ -69,6 +72,7 @@ func (cre *ChainEngine) IsAuthorized(ctx context.Context) error {
// and then be used for the whole chain of RBAC Engines.
rpcData, err := newRPCData(ctx)
if err != nil {
logger.Errorf("missing fields in ctx %+v: %v", ctx, err)
return status.Errorf(codes.Internal, "missing fields in ctx %+v: %v", ctx, err)
dfawley marked this conversation as resolved.
Show resolved Hide resolved
}
for _, engine := range cre.chainedEngines {
Expand Down