transport: return http-status when grpc-status is missing #4606

JNProtzman · 2021-07-21T02:01:47Z

This (hopefully) addresses @dfawley's comment.

RELEASE NOTES: n/a

dfawley · 2021-07-21T17:51:16Z

internal/transport/http2_client.go

@@ -1318,7 +1318,8 @@ func (t *http2Client) operateHeaders(frame *http2.MetaHeadersFrame) {
 				t.closeStream(s, se.Err(), true, http2.ErrCodeProtocol, se, nil, endStream)
 				return
 			}
-			rawStatusCode = codes.Code(uint32(code))
+			rsc := codes.Code(uint32(code))


Shouldn't ParseInt above be ParseUint?

And then we need a bounds check on this as well.

I adjusted this to ParseUint. What kind of bounds check should I do?

Hmm, nevermind the bounds checks. If we were to add a new status code, I believe we'd want to allow it to be propagated by a gRPC proxy without requiring recompilation of the proxy. So any unsigned value is fine here.

OK great. I think this is ready for re-review then!

dfawley · 2021-07-21T17:53:56Z

internal/transport/http2_client.go

@@ -1366,7 +1367,9 @@ func (t *http2Client) operateHeaders(frame *http2.MetaHeadersFrame) {
 	if !isGRPC || httpStatusErr != "" {
 		var code = codes.Internal // when header does not include HTTP status, return INTERNAL

-		if httpStatusCode != nil {
+		if rawStatusCode != nil {
+			code = *rawStatusCode


So now here is the big question: what if rawStatusCode is OK?

If you read the spec literally, we should ignore the HTTP status in this case. This appears to be what the other languages do as well, so I suppose we should do that, even though to me it appears to be covering up errors in the system. (@ejona86 @markdroth FYI)

As you mentioned - this results in potentially covering up an error. Here's an example in tests in this PR.

I don't think this part of the change is right. A missing content-type error should continue to take priority over a grpc-status of OK (though that's admittedly a gray area and also unlikely to happen). We should still use that precedence, but only change it so we take grpc-status over http-status if everything higher priority is okay.

I took a stab at this. I'm not 100% sure it's what you meant but I think it is. If we receive a grpc-status but have encountered another error, we'll take the http-status over the grpc-status. Otherwise, we'll default to the http-status.

dfawley · 2021-07-21T17:56:18Z

internal/transport/http2_client.go

+		if rawStatusCode == nil {
+			rsc := codes.Unknown
+			rawStatusCode = &rsc
+		}
+		statusGen = status.New(*rawStatusCode, grpcMessage)


Let's do this the other way around to avoid an allocation (even if it hopefully doesn't escape the stack):

if statusGen == nil { rsc := codes.Unknown if rawStatusCode != nil { rsc = *rawStatusCode } statusGen = status.New(rsc, grpcMessage) }

dfawley · 2021-08-18T18:00:09Z

Friendly ping on this PR as well - my comment 7d ago is hidden in a thread above, so I also wanted to make sure it's more obvious that this PR isn't blocked on me.

…atus

JNProtzman · 2021-08-23T01:57:57Z

I know the tests are failing but it seems like those might be unrelated. @dfawley, I think this is ready for your review again.

github-actions · 2021-08-29T02:47:15Z

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

…atus

dfawley · 2021-09-15T20:35:11Z

internal/transport/transport_test.go

@@ -2090,7 +2090,7 @@ func (s) TestClientDecodeHeaderStatusErr(t *testing.T) {
 			metaHeaderFrame: &http2.MetaHeadersFrame{
 				Fields: []hpack.HeaderField{
 					{Name: "content-type", Value: "application/grpc"},
-					{Name: "grpc-status", Value: "0"},
+					{Name: "grpc-status", Value: "14"},


If there is a grpc-status, then there should be a grpc-message to go along with it, or we should use the empty string like we do normally -- we should not be using the generated "unexpected HTTP status code" error message. At least, that's what it seems like it should be doing, though it's not mentioned in our docs. Does that seem right to you, @ejona86 / @markdroth?

Maybe set this error code to a different number and change the wantStatus code, so it is clear that's the source of the error, not the 504->Unavailable conversion?

I would say a grpc-message should go along with it from a "we don't hate ourselves" perspective. If there isn't a message, I wouldn't use an empty string; I'd leave the header missing. I wouldn't suggest a useless message like "UNAVAILABLE"; again, I'd prefer just not having it.

But that's a bit neither here nor there. In this case, there is a grpc-status, so you should use that and the grpc-message if it isn't present. I don't think this test is correct: the status shouldn't have a status description.

I'd leave the header missing

This is client-side. If the header is missing, the client would use "" as the message string presented to the user. (We have to give them some string, since it's returned as a string value; we can't use nil.)

Ah, then yeah, empty string seems appropriate for your API. Java's API lets the description (which we call grpc-message) be null. Makes sense that you wouldn't have such a distinction in Go.

Ping @JNProtzman, I think this is the last issue: to not use the generated http error message along with the grpc-status header value in the status returned to the user.

@dfawley sorry for the delay here. I'm currently in Iceland and have plans to travel through Europe until Nov. 1st. I won't be able to pick this up until then... sorry!

dfawley · 2021-11-17T18:40:44Z

Ping @JNProtzman - hope all is well. Have you returned, and are you able to pick this PR up again?

github-actions · 2021-11-23T18:47:51Z

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

Only return http status when grpc status is missing

3e948ab

JNProtzman mentioned this pull request Jul 21, 2021

transport: validate http 200 status for responses #4474

Merged

menghanl requested a review from dfawley July 21, 2021 17:50

menghanl assigned dfawley Jul 21, 2021

dfawley reviewed Jul 21, 2021

View reviewed changes

dfawley assigned JNProtzman and unassigned dfawley Jul 21, 2021

ParseUint, not ParseInt and avoid alloc

008beeb

JNProtzman requested a review from dfawley July 23, 2021 02:55

dfawley added the Status: Requires Reporter Clarification label Aug 18, 2021

JNProtzman added 3 commits August 22, 2021 21:23

grpc-status over http-status if everything else is good

fbb727b

Merge branch 'master' of https://github.com/grpc/grpc-go into grpc_st…

64e41a7

…atus

Trigger workflow run

ae2fd9c

github-actions bot added the stale label Aug 29, 2021

dfawley removed the Status: Requires Reporter Clarification label Aug 30, 2021

Merge branch 'master' of https://github.com/grpc/grpc-go into grpc_st…

e9a576e

…atus

dfawley reviewed Sep 15, 2021

View reviewed changes

dfawley added this to the 1.42 Release milestone Sep 21, 2021

dfawley added Type: Bug Status: Requires Reporter Clarification and removed stale labels Sep 29, 2021

dfawley removed the Status: Requires Reporter Clarification label Oct 8, 2021

menghanl modified the milestones: 1.42 Release, 1.43 release Oct 29, 2021

dfawley added the Status: Requires Reporter Clarification label Nov 17, 2021

github-actions bot added the stale label Nov 23, 2021

github-actions bot closed this Nov 30, 2021

github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

transport: return http-status when grpc-status is missing #4606

transport: return http-status when grpc-status is missing #4606

JNProtzman commented Jul 21, 2021 •

edited by dfawley

dfawley Jul 21, 2021

JNProtzman Jul 22, 2021

dfawley Jul 22, 2021

JNProtzman Jul 23, 2021

dfawley Jul 21, 2021

JNProtzman Jul 22, 2021

dfawley Aug 11, 2021

JNProtzman Aug 23, 2021

dfawley Jul 21, 2021

JNProtzman Jul 22, 2021

dfawley commented Aug 18, 2021

JNProtzman commented Aug 23, 2021

github-actions bot commented Aug 29, 2021

dfawley Sep 15, 2021

ejona86 Sep 15, 2021

dfawley Sep 15, 2021

ejona86 Sep 15, 2021

dfawley Sep 29, 2021

JNProtzman Oct 7, 2021

dfawley commented Nov 17, 2021

github-actions bot commented Nov 23, 2021

transport: return http-status when grpc-status is missing #4606

transport: return http-status when grpc-status is missing #4606

Conversation

JNProtzman commented Jul 21, 2021 • edited by dfawley

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfawley commented Aug 18, 2021

JNProtzman commented Aug 23, 2021

github-actions bot commented Aug 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfawley commented Nov 17, 2021

github-actions bot commented Nov 23, 2021

JNProtzman commented Jul 21, 2021 •

edited by dfawley