Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binarylog: Don't leak the flusher goroutine when closing a Sink #4583

Merged
merged 1 commit into from Jul 7, 2021
Merged

binarylog: Don't leak the flusher goroutine when closing a Sink #4583

merged 1 commit into from Jul 7, 2021

Commits on Jul 3, 2021

  1. binarylog: Don't leak the flusher goroutine when closing a Sink 

    time.Ticker.Stop() doesn't close the ticker channel, so we need to signal the goroutine to die some other way
    @Jille
    Jille committed Jul 3, 2021
    Copy the full SHA
    a8e6516 View commit details
    Browse the repository at this point in the history