Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/transport: do not mask ConnectionError #4561

Merged
merged 2 commits into from Jun 28, 2021
Merged

Commits on Jun 22, 2021

  1. internal/transport: do not mask ConnectionError

    PR grpc#4316 updates the http2Client `Close` method so it can append
    additional debug information about prior GOAWAY messages before this
    connection was closed.
    
    However, it is not safe to do this in the general case, as the original
    error is propagated through the connection's `Stream` via a `recvMsg`,
    and read later on. If the additional metadata is appended by wrapping
    the error with `fmt.Errorf`, downstream clients will not be able to
    detect meaningful error conditions (such as `io.EOF`) or the temporarity
    of the error.
    
    Fix this by properly wrapping the original error with `connectionErrorf`
    like it is done for all the other errors in the client.
    vmg committed Jun 22, 2021
    Copy the full SHA
    2650a2f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. internal/transport: build a proper status

    Signed-off-by: Vicent Marti <vmg@strn.cat>
    vmg committed Jun 24, 2021
    Copy the full SHA
    7166e06 View commit details
    Browse the repository at this point in the history