Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: prevent deadlock in Test/ClientUpdatesParamsAfterGoAway on failure #4534

Merged
merged 2 commits into from Jun 11, 2021
Merged

grpc: prevent deadlock in Test/ClientUpdatesParamsAfterGoAway on failure #4534

merged 2 commits into from Jun 11, 2021

Commits on Jun 10, 2021

  1. Prevent hang in Test/ClientUpdatesParamsAfterGoAway 

    In cases where `t.Fatalf()` doesn't completely end the program, a `ctx.Err()` will cause the program to wait on a mutex indefinitely. 

Forcing the test to enter this specific `if` condition should reproduce the issue.

Adding an unlock before reporting the error allows the program to fail the test as intended when a network error occurs.
    @dustin-ward
    dustin-ward committed Jun 10, 2021
    Copy the full SHA
    c04bfb1 View commit details
    Browse the repository at this point in the history

  2. Move RUnlock outside of conditionals

    @dustin-ward
    dustin-ward committed Jun 10, 2021
    Copy the full SHA
    42ff2ae View commit details
    Browse the repository at this point in the history