Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: skip CSDS on failure instead of aborting #4486

Closed
wants to merge 1 commit into from
Closed

admin: skip CSDS on failure instead of aborting #4486

wants to merge 1 commit into from

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented May 25, 2021 •
edited by dfawley

fixes #4400

RELEASE NOTES:

  • admin: skip CSDS if xDS bootstrap config isn't set

@menghanl menghanl added the Type: Behavior Change Behavior changes not categorized as bugs label May 25, 2021
@menghanl menghanl added this to the 1.39 Release milestone May 25, 2021
@menghanl menghanl requested a review from dfawley May 25, 2021 20:33
@menghanl menghanl changed the title service/admin: skip services with error instead of failing service/admin: skip CSDS on failure instead of aborting May 25, 2021
@dfawley dfawley changed the title service/admin: skip CSDS on failure instead of aborting admin: skip CSDS on failure instead of aborting May 25, 2021
@dfawley dfawley assigned menghanl and unassigned dfawley May 25, 2021
@menghanl
Copy link
Contributor Author

menghanl commented Jun 1, 2021

Replaced by #4505

@menghanl menghanl closed this Jun 1, 2021
@menghanl menghanl deleted the admin_skip_csds branch June 1, 2021 22:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Milestone
1.39 Release
Development

Successfully merging this pull request may close these issues.

admin service errors if xds imported but no bootstrap exists
2 participants
@menghanl @dfawley