Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: propagate connection error causes to RPC statuses #4311

Merged
merged 12 commits into from Apr 13, 2021
Merged

client: propagate connection error causes to RPC statuses #4311

merged 12 commits into from Apr 13, 2021

Commits on Apr 1, 2021

  1. Propagate errors causing connection close to RPC statuses

    @apolcyn
    apolcyn committed Apr 1, 2021
    Copy the full SHA
    ba8e17b View commit details
    Browse the repository at this point in the history

  2. fix transport tests

    @apolcyn
    apolcyn committed Apr 1, 2021
    Copy the full SHA
    0640203 View commit details
    Browse the repository at this point in the history

  3. Make test deterministic

    @apolcyn
    apolcyn committed Apr 1, 2021
    Copy the full SHA
    38da1fd View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Address most review comments; TODO: find specific reason for ECONNRST 

    error
    @apolcyn
    apolcyn committed Apr 12, 2021
    Copy the full SHA
    05425bc View commit details
    Browse the repository at this point in the history

  2. don't pass nil error to Close

    @apolcyn
    apolcyn committed Apr 12, 2021
    Copy the full SHA
    2096b3c View commit details
    Browse the repository at this point in the history

  3. Don't pass nil to Close in keepalive test

    @apolcyn
    apolcyn committed Apr 12, 2021
    Copy the full SHA
    29e6854 View commit details
    Browse the repository at this point in the history

  4. fix keepalive test

    @apolcyn
    apolcyn committed Apr 12, 2021
    Copy the full SHA
    622a2be View commit details
    Browse the repository at this point in the history

  5. Fix keepalive test

    @apolcyn
    apolcyn committed Apr 12, 2021
    Copy the full SHA
    05ced4d View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. improve comment and test

    @apolcyn
    apolcyn committed Apr 13, 2021
    Copy the full SHA
    83679d0 View commit details
    Browse the repository at this point in the history

  2. use WithBlock

    @apolcyn
    apolcyn committed Apr 13, 2021
    Copy the full SHA
    bb3a1ee View commit details
    Browse the repository at this point in the history

  3. Revert use of WithBlock, go back to rpcStartedOnServer channel

    @apolcyn
    apolcyn committed Apr 13, 2021
    Copy the full SHA
    1c4fb15 View commit details
    Browse the repository at this point in the history

  4. Address comments

    @apolcyn
    apolcyn committed Apr 13, 2021
    Copy the full SHA
    6db7094 View commit details
    Browse the repository at this point in the history