Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added server side check for POST method #4237

Closed
wants to merge 1 commit into from
Closed

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Mar 2, 2021

Fixes issue #2881.

Added check to after HTTP/2 stream logic checks in order for the precedence of error checking to account for HTTP/2 first, as gRPC rests on top of HTTP/2.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@zasweq zasweq added no release notes Type: Behavior Change Behavior changes not categorized as bugs Type: Internal Cleanup Refactors, etc labels Mar 2, 2021
@zasweq zasweq requested a review from dfawley March 2, 2021 23:11
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to verify the new behavior? Thanks.

@zasweq
Copy link
Contributor Author

zasweq commented Mar 2, 2021

Will do!

@easwars
Copy link
Contributor

easwars commented Mar 2, 2021

@dfawley We probably need to add this to the release notes, right?

@dfawley dfawley added Type: Bug and removed Type: Behavior Change Behavior changes not categorized as bugs Type: Internal Cleanup Refactors, etc no release notes labels Mar 2, 2021
@dfawley dfawley added this to the 1.37 Release milestone Mar 2, 2021
@zasweq zasweq closed this Mar 4, 2021
@dfawley dfawley deleted the check-for-post branch March 4, 2021 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants