Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow only post method for making requests #3145

Closed
wants to merge 1 commit into from

Conversation

oneslash
Copy link

@oneslash oneslash commented Nov 5, 2019

Allow only POST for the requests.

fixes: #2881

@menghanl
Copy link
Contributor

menghanl commented Nov 7, 2019

This seems to have broken the tests, can you look at them? Thanks.

@dfawley
Copy link
Member

dfawley commented Nov 14, 2019

@oneslash can you take a look at the tests and see what's wrong? Thanks.

@menghanl menghanl changed the title fix: allow only post method for making requests fixes: #2881 fix: allow only post method for making requests Nov 14, 2019
@stale
Copy link

stale bot commented Nov 21, 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@stale stale bot added the stale label Nov 21, 2019
@oneslash
Copy link
Author

oh, I will fix soon

@stale stale bot removed the stale label Nov 21, 2019
@stale
Copy link

stale bot commented Nov 28, 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@stale stale bot added the stale label Nov 28, 2019
@stale stale bot closed this Dec 5, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc: propagate error and http status to caller when received HTTP method is not POST
3 participants