Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: client keepalives should be sent every [Time] period #3102

Merged
merged 5 commits into from Oct 24, 2019
Merged

transport: client keepalives should be sent every [Time] period #3102

merged 5 commits into from Oct 24, 2019

Commits on Oct 15, 2019

  1. Keepalive pings should be sent every [Time] period 

    This commit makes the following changes:
- Keep track of the time of the last read in the transport.
- Use this in the keepalive implementation to decide when to send out
  keepalives.
- Address the issue of keepalives being sent every [Time+Timeout] period
  instead of every [Time] period, as mandated by proposal A8.

Proposal A8 is here:
https://github.com/grpc/proposal/blob/master/A8-client-side-keepalive.md
    @easwars
    easwars committed Oct 15, 2019
    Copy the full SHA
    f558887 View commit details
    Browse the repository at this point in the history

  2. Make this work on 32-bit machines.

    @easwars
    easwars committed Oct 15, 2019
    Copy the full SHA
    331a6b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Review comments.

    @easwars
    easwars committed Oct 16, 2019
    Copy the full SHA
    a6cd9a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Review comments.

    @easwars
    easwars committed Oct 23, 2019
    Copy the full SHA
    65d67ac View commit details
    Browse the repository at this point in the history

  2. Review comments.

    @easwars
    easwars committed Oct 23, 2019
    Copy the full SHA
    0c72230 View commit details
    Browse the repository at this point in the history